diff options
| author | Xavier Chantry <shiningxc@gmail.com> | 2009-10-12 23:05:36 +0200 |
|---|---|---|
| committer | Dan McGee <dan@archlinux.org> | 2009-10-20 22:25:39 -0500 |
| commit | 2c2596177d88a60cbef8154927f847ca214aadd0 (patch) | |
| tree | 6fc2e541d6a5980148054720a9bb72e9f7da8b38 | |
| parent | 3d67d9b16c53fe70c1b7149b5a6bfbbf17522ba3 (diff) | |
dload.c : clear sigaction flag to make valgrind happy
This fixes the following valgrind warning :
==26831== Syscall param rt_sigaction(act->sa_flags) points to uninitialised
byte(s)
==26831== at 0x4282547: __libc_sigaction (in /lib/libc-2.10.1.so)
==26831== by 0x403C693: download_internal (dload.c:152)
==26831== by 0x403D0E4: _alpm_download_single_file (dload.c:311)
==26831== by 0x4033B72: alpm_db_update (be_files.c:319)
==26831== by 0x805205E: pacman_sync (sync.c:257)
==26831== by 0x804EE54: main (pacman.c:1120)
==26831== Address 0xbec6cc04 is on thread 1's stack
==26831==
==26831== Syscall param rt_sigaction(act->sa_restorer) points to
uninitialised byte(s)
==26831== at 0x4282547: __libc_sigaction (in /lib/libc-2.10.1.so)
==26831== by 0x403C693: download_internal (dload.c:152)
==26831== by 0x403D0E4: _alpm_download_single_file (dload.c:311)
==26831== by 0x4033B72: alpm_db_update (be_files.c:319)
==26831== by 0x805205E: pacman_sync (sync.c:257)
==26831== by 0x804EE54: main (pacman.c:1120)
==26831== Address 0xbec6cc08 is on thread 1's stack
==26831==
Signed-off-by: Xavier Chantry <shiningxc@gmail.com>
Signed-off-by: Dan McGee <dan@archlinux.org>
| -rw-r--r-- | lib/libalpm/dload.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c index 4989d4ac..a4c9f1f4 100644 --- a/lib/libalpm/dload.c +++ b/lib/libalpm/dload.c @@ -147,6 +147,7 @@ static int download_internal(const char *url, const char *localpath, * something along those lines. Store the old signal handler first. */ new_action.sa_handler = SIG_IGN; sigemptyset(&new_action.sa_mask); + new_action.sa_flags = 0; sigaction(SIGPIPE, NULL, &old_action); sigaction(SIGPIPE, &new_action, NULL); |