summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAaron Griffin <aaron@archlinux.org>2007-01-19 17:42:58 +0000
committerAaron Griffin <aaron@archlinux.org>2007-01-19 17:42:58 +0000
commit66cfa9826ebfc99042fd6ad1a778438d1b21bdc0 (patch)
tree0e8cd5148bc7dbf9b2900e95f2fc4c5265488120
parent616701726425417989ef1dca145b805deae6fe93 (diff)
Added some things I noticed when making alpm_list changes, but didn't want to change too much at once.
-rw-r--r--TODO.aaron28
1 files changed, 25 insertions, 3 deletions
diff --git a/TODO.aaron b/TODO.aaron
index cd441c56..8fad56b8 100644
--- a/TODO.aaron
+++ b/TODO.aaron
@@ -1,10 +1,32 @@
== This is my custom TODO file ==
-This (second) test should shoot a commit email to the pacman-dev list.
+* Make sure all the alpm_list_t changes are valid (especially alpm_list_free)
-* pacman: ALOT of functions are way too long. There should be an upper limit of
+* src/pacman:
+ - There's quite a few single function headers which contain the pacman_*
+ functions. We should move these to a single header (pacman.h) to clean up
+ the source a bit.
+ - config_t duplicates much of what can be accessed from the alpm_option_*
+ interface. Determine what can / can't be removed and do so.
+ - initialize alpm BEFORE parsing args, so we can get rid of a handful of
+ local lists and things in pacman.c (see below)
+ - fix the "--debug" parameter. requiring a bitmask from the user is silly.
+ we can parse this can send a real bitmask to alpm.
+
+* lib/libalpm:
+ - Remove `root` param from alpm_initialize. We can simply initialize to /
+ and call set_root at a later time. This allows us to initiliaze earlier.
+ - move logging (alpm_logaction) out of the library. log files should be
+ written by the app, not the library. Adding a PM_LOG_* constant that
+ frontends can recognize and send to a file is probably a good idea.
+ - maybe it's my fault, but I see little difference between PM_LOG_FLOW1,
+ PM_LOG_FLOW2, and PM_LOG_DEBUG. We might want to just do away with flow1
+ and flow2 and use debug across the board.
+
+* pacman: A LOT of functions are way too long. There should be an upper limit of
100-200 lines. _alpm_add_commit is around 600 lines, and is far too complex.
- Quite alot of this needs to be refactored as we go.
+
+ Quite a lot of this needs to be refactored as we go.
Function list (from Dan McGee):
add.c:
_alpm_add_commit