diff options
author | Allan McRae <allan@archlinux.org> | 2010-06-19 18:55:08 +1000 |
---|---|---|
committer | Allan McRae <allan@archlinux.org> | 2010-06-21 01:04:58 +1000 |
commit | 59c47aaf529df02ec1577fe727c3c84d13592666 (patch) | |
tree | 63049bcc89e7058376ce0607ddee116b2f819ddc /src/pacman/callback.c | |
parent | d7dccd541962f0dd8bf323ae11633e595bfb4922 (diff) |
Clarify testing within conditional statements
Follow the HACKING guidelines and always use != 0 or == 0 rather
than negation within conditional statements to improve clarity.
Most of these are !strcmp usages which is the example of what not
to do in the HACKING document.
Signed-off-by: Allan McRae <allan@archlinux.org>
Diffstat (limited to 'src/pacman/callback.c')
-rw-r--r-- | src/pacman/callback.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/pacman/callback.c b/src/pacman/callback.c index f5bf17d1..23804d7c 100644 --- a/src/pacman/callback.c +++ b/src/pacman/callback.c @@ -262,7 +262,7 @@ void cb_trans_conv(pmtransconv_t event, void *data1, void *data2, case PM_TRANS_CONV_CONFLICT_PKG: /* data parameters: target package, local package, conflict (strings) */ /* print conflict only if it contains new information */ - if(!strcmp(data1, data3) || !strcmp(data2, data3)) { + if(strcmp(data1, data3) == 0 || strcmp(data2, data3) == 0) { *response = noyes(_(":: %s and %s are in conflict. Remove %s?"), (char *)data1, (char *)data2, |