diff options
| author | Jeremy Heiner <scalaprotractor@gmail.com> | 2013-10-12 12:44:33 -0400 |
|---|---|---|
| committer | Allan McRae <allan@archlinux.org> | 2013-10-14 13:01:15 +1000 |
| commit | 95b0a868f255f2766ae03733882f30c8c7f3b7ca (patch) | |
| tree | 49ee07b8cf5778b47a5037415f322aaa78b2f15d /test/pacman/pmpkg.py | |
| parent | 071ba05534f1e5f3eee3435214caa2642e3e2c23 (diff) | |
Use dict iteration methods common to both Python 2 and 3.
The .items, .keys, and .values methods in Python 2 make copies, so the
test framework uses the .iter* flavors of those methods. But in Python
3 those .iter* (and even the 2.7 .view*) flavors are removed and the
original methods return views.
Measurements were taken under Python2 to see what impact the copying
had, and there was none. Thus it is not worth the effort to avoid.
Reported as a compatibility issue by 2to3.
Signed-off-by: Jeremy Heiner <ScalaProtractor at gmail.com>
Signed-off-by: Allan McRae <allan@archlinux.org>
Diffstat (limited to 'test/pacman/pmpkg.py')
| -rw-r--r-- | test/pacman/pmpkg.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/pacman/pmpkg.py b/test/pacman/pmpkg.py index 24ef1e2b..6f7ae6e1 100644 --- a/test/pacman/pmpkg.py +++ b/test/pacman/pmpkg.py @@ -223,7 +223,7 @@ class pmpkg(object): def installfile(self): data = [] - for key, value in self.install.iteritems(): + for key, value in self.install.items(): if value: data.append("%s() {\n%s\n}\n" % (key, value)) |