summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* alpm_list: fix typo in doxygen commentPang Yan Han2011-05-24
| | | | | Signed-off-by: Pang Yan Han <pangyanhan@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
* Bail early if we don't have a valid lockfile pathDan McGee2011-05-19
| | | | | | | | | | | | | | This addresses FS#24292. If one does the bad thing of not checking pm_errno after calling set_dbpath(), you may not realize the initialization process went wrong and calling trans_init() resulted in a segfault. If we don't have a lockfile path, bail out and have trans_init() fail. Also remove a ALPM_LOG_FUNC call that was causing pm_errno to return "no handle"; this was due to a log call in the handle setup (whereby the log attempts to use a callback attached to the handle). Signed-off-by: Dan McGee <dan@archlinux.org>
* Coding style cleanups; add a null checkDan McGee2011-05-19
| | | | Signed-off-by: Dan McGee <dan@archlinux.org>
* Ensure --print doesn't enable --noconfirm when not expectedDan McGee2011-05-16
| | | | | | | | This is at best a hack around the way we currently do our --print magic, but at least prevents someone from shooting themselves in the foot as indicated in FS#24287. Signed-off-by: Dan McGee <dan@archlinux.org>
* Fix segfault when uninstalling broken backed-up symlinkDan McGee2011-05-16
| | | | | | | | | Issue FS#24230. If a symlink is broken and included in the removal process of a package, we blew up and segfaulted due to alpm_compute_md5sum() returning NULL and then performing a strcmp() operation. Signed-off-by: Dan McGee <dan@archlinux.org>
* Add test for FS#24230, dead backup symlink removalDan McGee2011-05-16
| | | | | | This currently causes a segfault, which is bad news. Signed-off-by: Dan McGee <dan@archlinux.org>
* pactest: treat symlinks with more respectDan McGee2011-05-16
| | | | | | | | Don't call os.stat() when we should be using os.lstat(); this allows us to actually test dead symlinks that don't have a corresponding file. Add a new LINK_EXIST rule that complements FILE_EXIST for a similar purpose. Signed-off-by: Dan McGee <dan@archlinux.org>
* Transifex updatesDan McGee2011-05-16
| | | | Signed-off-by: Dan McGee <dan@archlinux.org>
* trans.c: create transaction prior to checking DB versionDave Reisner2011-05-16
| | | | | | | | | | | The addition of the DB version check introduces a lag time between the lockfile creation and the transaction initialization. In cases where the local DB is large enough and/or the user's disk is slow enough, this time is significant enough that its possible for a user to send a SIGINT and leave behind a db.lck file. Signed-off-by: Dave Reisner <d@falconindy.com> Signed-off-by: Dan McGee <dan@archlinux.org>
* Ensure populate error return codes are consistentDan McGee2011-05-05
| | | | | | | It must be -1 to differentiate it from a number of packages loaded count. Signed-off-by: Dan McGee <dan@archlinux.org>
* makepkg: quote variable that may contain spacesAllan McRae2011-05-02
| | | | | | | | Prevents failures when $PKGDEST contains spaces (FS#24002) Patch-by: Sebastien Duthil Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
* Update PKGBUILD exampleAllan McRae2011-05-02
| | | | | | | | Add quotes around $srcdir/$pkgdir (FS#23960) and use a package() function. Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
* Transifex updatesDan McGee2011-04-29
| | | | Signed-off-by: Dan McGee <dan@archlinux.org>
* pacman(8): grammar correction for relative clausesMatt Mooney2011-04-29
| | | | | | | | | | Change "which" to "that" when used in a restrictive clause. Replace usage of the relative prounoun "those" with a common noun for added clarity. Signed-off-by: Matt Mooney <mfm@muteddisk.com> Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
* pacman(8): change "options" to "operation" when referring to -DMatt Mooney2011-04-29
| | | | | | | -D is an operation not an option. Signed-off-by: Matt Mooney <mfm@muteddisk.com> Signed-off-by: Allan McRae <allan@archlinux.org>
* Small translation update from TransifexDan McGee2011-04-22
| | | | Signed-off-by: Dan McGee <dan@archlinux.org>
* doc/pacman: split -Su description in 3 paragraphsXavier Chantry2011-04-20
| | | | | | | One paragraph for -Suu and one for -Su foo. Fixes FS#23451. Signed-off-by: Xavier Chantry <chantry.xavier@gmail.com> Signed-off-by: Dan McGee <dan@archlinux.org>
* Final updates for 3.5.2 releaseDan McGee2011-04-18
| | | | Signed-off-by: Dan McGee <dan@archlinux.org>
* 3.5.2 translation updates from TransifexDan McGee2011-04-18
| | | | | | And also a POT version and package version update. Signed-off-by: Dan McGee <dan@archlinux.org>
* pacman/query: correctly handle root files with -QoXavier Chantry2011-04-15
| | | | | | | | spotted by clang-analyzer (strcmp with NULL rpath is bad) Signed-off-by: Xavier Chantry <chantry.xavier@gmail.com> Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
* makepkg.sh.in: fix a GNU-ism in su invocationRémy Oudompheng2011-04-13
| | | | | | | | | | | | GNU su supports the -c option to specify a command to execute. However, other flavours of su may have a different interpretation of the '-c' flag (e.g. FreeBSD and OpenBSD). The behaviour is correct when '-c' follows an explicit username. Signed-off-by: Rémy Oudompheng <remy@archlinux.org> Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
* alpm.h: fix typos in documentationRémy Oudompheng2011-04-13
| | | | Signed-off-by: Rémy Oudompheng <remy@archlinux.org>
* Remove Korean language translation filesDan McGee2011-04-12
| | | | | | | There is no actual translation done here yet, just a dormant Transifex language with nothing checked in. Signed-off-by: Dan McGee <dan@archlinux.org>
* bacman: fix the fact that the depends file no longer existsDan McGee2011-04-09
| | | | | | Addresses FS#23641. Signed-off-by: Dan McGee <dan@archlinux.org>
* alpm.h: document transaction flagsRémy Oudompheng2011-04-09
| | | | Signed-off-by: Rémy Oudompheng <remy@archlinux.org>
* More documentation for option getters/setters.Rémy Oudompheng2011-04-09
|
* alpm.h: more documentation for pkgreason, depend and errno.Rémy Oudompheng2011-04-09
|
* Move documentation for public package function to alpm.hRémy Oudompheng2011-04-09
|
* alpm.h: organize doxygen documentation in groupsRémy Oudompheng2011-04-09
|
* Move documentation of public database functions to alpm.hRémy Oudompheng2011-04-09
|
* alpm.h: add documentation for package property accessorsRémy Oudompheng2011-04-09
|
* Move documentation of public transaction functions to alpm.hRémy Oudompheng2011-04-09
|
* Fix broken documentation for alpm_trans_prepare()Rémy Oudompheng2011-04-09
| | | | | | | The current state of the code does not allow to see immediately that it returns a list of pmdepmissing_t structures. Signed-off-by: Dan McGee <dan@archlinux.org>
* libalpm: set pm_errno correctly in alpm_trans_get_flags()Rémy Oudompheng2011-04-09
| | | | Signed-off-by: Dan McGee <dan@archlinux.org>
* diskspace: add the actually used statfs type in ifdefsRémy Oudompheng2011-04-06
| | | | | | | | | | Some systems, like FreeBSD might define both statfs and statvfs: however if statvfs exists whereas getmntinfo() uses a statfs struct, the current ifdefs would select the wrong line of code. Signed-off-by: Rémy Oudompheng <remy@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
* libalpm/be_local.c: unused variable entXavier Chantry2011-04-04
| | | | | | spotted by clang analyzer Signed-off-by: Xavier Chantry <chantry.xavier@gmail.com>
* libalpm/pkghash.c: unused variable ptrXavier Chantry2011-04-04
| | | | | | spotted by clang analyzer Signed-off-by: Xavier Chantry <chantry.xavier@gmail.com>
* makepkg: fix a GNU-ism in awk usageRémy Oudompheng2011-04-04
| | | | | | | | | | A non-GNU version of awk may not support the (|...) syntax for an optional group and require '()' to match an empty string. The (...)? syntax is more appropriate for this usage. Signed-off-by: Rémy Oudompheng <remy@archlinux.org> Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
* makepkg: improve parsing for sanity checksAllan McRae2011-04-04
| | | | | | | | | Trailing backslahses can lead to additional spaces at the front of extracted entries. See FS#23524. Strip these while parsing the PKGBUILD entries. Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
* db.c: set pm_errno appropriately in alpm_db_set_pkgreason()Rémy Oudompheng2011-04-04
| | | | | Signed-off-by: Rémy Oudompheng <remy@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
* Coding style cleanupsDan McGee2011-04-04
| | | | Signed-off-by: Dan McGee <dan@archlinux.org>
* test: fix invalid usage of 'type -p'Dan McGee2011-04-04
| | | | | | | | | | | | | | | | | The vercmptest script needs to be invoked as a bash script for this to be valid; the -p operator is interpreted as an argument to look up by sh. This goes way back to commit 3bf9448943dc0b, done to solve http://mailman.archlinux.org/pipermail/pacman-dev/2008-July/007180.html. Saw this problem running in a virtual machine where sh is not bash, but in fact dash: user@debian-powerpc:~/projects/pacman$ ./test/util/vercmptest.sh src/util/vercmp-p: not found src/util/vercmp is src/util/vercmp vercmp binary (src/util/vercmp) could not be located Signed-off-by: Dan McGee <dan@archlinux.org>
* util.c: include limits.h for PATH_MAX macroRémy Oudompheng2011-04-02
| | | | | Signed-off-by: Rémy Oudompheng <remy@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
* Fix compatibility with older versions of libarchive.Rémy Oudompheng2011-04-02
| | | | | | | | | There is no reason to not support versions of libarchive that lack ARCHIVE_COMPRESSION_UU. Distributions should work properly without this. Signed-off-by: Rémy Oudompheng <remy@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
* Ensure stdout/stderr are flushed when asking questionsDan McGee2011-04-01
| | | | | | | | | Addresses FS#23492, where the question was shown without knowing what one was answering to. Ensure we flush our output streams before printing the question, and flush the stream on which we ask the question before waiting for an answer. Signed-off-by: Dan McGee <dan@archlinux.org>
* Add default changelog functions to pkg_operationsDan McGee2011-04-01
| | | | | | | | So we don't segfault when calling this on be_sync loaded packages. They return logical values as much as possible for indicating there is no changelog available. Signed-off-by: Dan McGee <dan@archlinux.org>
* Ensure dbpath is not null when populating sync databaseDan McGee2011-04-01
| | | | | | | | | | | | | | | | | | | | | | We didn't do this sanity check before trying to open an archive. If the alpm dbpath wasn't set, the sync database dbpath would be NULL, causing us to hang indefinitely in archive_read_open_filename() rather than erroring out. We already have a corresponding check in local_db_populate(). The following program will test this case, and hangs before this patch without the call to set_dbpath: int main(int argc, char *argv[]) { alpm_initialize(); // alpm_option_set_dbpath("/var/lib/pacman/"); pmdb_t *core = alpm_db_register_sync("core"); pmpkg_t *pkg = alpm_db_get_pkg(core, "pacman"); return 0; } Signed-off-by: Dan McGee <dan@archlinux.org>
* Ignore upcoming new values in sync backendDan McGee2011-04-01
| | | | | | | PGPSIG and SHA256SUM are new and we can safely ignore them for now if we come across them. Signed-off-by: Dan McGee <dan@archlinux.org>
* makepkg: remove unnecessary tr usageAllan McRae2011-03-30
| | | | | | | | The use of "tr" only leads to trouble. Remove unnecessary usage of it from within makepkg. Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
* makepkg: avoid usage of tr to sidestep locale issuesDave Reisner2011-03-30
| | | | | | | | | to quote dan: "turkish will FUCK YOU UP. this is not the first or the last time" Signed-off-by: Dave Reisner <d@falconindy.com> Signed-off-by: Allan McRae <allan@archlinux.org> Signed-off-by: Dan McGee <dan@archlinux.org>
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-10 00:20:11 +0000