From 63087c31b5bdd7a16d312d9bf938f6cfd4a635b0 Mon Sep 17 00:00:00 2001 From: Andrew Gregory Date: Wed, 10 May 2017 18:54:56 -0400 Subject: check for overflow when setting HTTP_USER_AGENT gcc7 issues a warning about a potential overflow if left unchecked. Signed-off-by: Andrew Gregory Signed-off-by: Allan McRae --- src/pacman/pacman.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 605aec3e..11b7e6f0 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -271,10 +271,15 @@ static void setuseragent(void) { char agent[101]; struct utsname un; + int len; uname(&un); - snprintf(agent, 100, "pacman/%s (%s %s) libalpm/%s", + len = snprintf(agent, 100, "pacman/%s (%s %s) libalpm/%s", PACKAGE_VERSION, un.sysname, un.machine, alpm_version()); + if(len >= 100) { + pm_printf(ALPM_LOG_WARNING, _("HTTP_USER_AGENT truncated\n")); + } + setenv("HTTP_USER_AGENT", agent, 0); } -- cgit v1.2.3-70-g09d2