From dea9b3bc0f6ba49aec8452958f5373fbb20e7df2 Mon Sep 17 00:00:00 2001 From: Dan McGee Date: Wed, 31 Oct 2007 11:43:04 -0500 Subject: Fix basename usage in pacman and utilities basename() is a rather untrusty function call on a lot of platforms as it does some weird and different things. To solve this, I added a mbasename fuction to pacman to take its place, and simply removed its usage in the utilities (it isn't worth dealing with there). Signed-off-by: Dan McGee --- src/pacman/pacman.c | 36 +++++++++++++++++++++++++++++------- 1 file changed, 29 insertions(+), 7 deletions(-) (limited to 'src/pacman/pacman.c') diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 05ae8d13..3859c8d3 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -57,15 +57,15 @@ static alpm_list_t *pm_targets; * @param op the operation code requested * @param myname basename(argv[0]) */ -static void usage(int op, char *myname) +static void usage(int op, const char * const myname) { /* prefetch some strings for usage below, which moves a lot of calls * out of gettext. */ - char * const str_opt = _("options"); - char * const str_file = _("file"); - char * const str_pkg = _("package"); - char * const str_usg = _("usage"); - char * const str_opr = _("operation"); + char const * const str_opt = _("options"); + char const * const str_file = _("file"); + char const * const str_pkg = _("package"); + char const * const str_usg = _("usage"); + char const * const str_opr = _("operation"); if(op == PM_OP_MAIN) { printf("%s: %s <%s> [...]\n", str_usg, myname, str_opr); @@ -233,6 +233,28 @@ static void cleanup(int signum) exit(signum); } +/** Parse the basename of a program from a path. +* Grabbed from the uClibc source. +* @param path path to parse basename from +* +* @return everything following the final '/' +*/ +static char *mbasename(const char *path) +{ + const char *s; + const char *p; + + p = s = path; + + while (*s) { + if (*s++ == '/') { + p = s; + } + } + + return (char *)p; +} + /** Parse command-line arguments for each operation. * @param argc argc * @param argv argv @@ -432,7 +454,7 @@ static int parseargs(int argc, char *argv[]) } if(config->help) { - usage(config->op, basename(argv[0])); + usage(config->op, mbasename(argv[0])); return(2); } if(config->version) { -- cgit v1.2.3-70-g09d2