summaryrefslogtreecommitdiff
path: root/lib/libalpm/conflict.c
blob: 91fd794d7c5a2c771f6e463caf347b502df34a77 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
/*
 *  conflict.c
 *
 *  Copyright (c) 2002-2006 by Judd Vinet <jvinet@zeroflux.org>
 *  Copyright (c) 2005 by Aurelien Foret <orelien@chez.com>
 *  Copyright (c) 2006 by David Kimpe <dnaku@frugalware.org>
 *  Copyright (c) 2006 by Miklos Vajna <vmiklos@frugalware.org>
 *  Copyright (c) 2006 by Christian Hamar <krics@linuxforum.hu>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License
 *  along with this program; if not, write to the Free Software
 *  Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307,
 *  USA.
 */

#include "config.h"

#include <stdlib.h>
#include <stdio.h>
#include <unistd.h>
#include <string.h>
#include <limits.h>
#include <sys/stat.h>

/* libalpm */
#include "conflict.h"
#include "alpm_list.h"
#include "handle.h"
#include "trans.h"
#include "util.h"
#include "error.h"
#include "log.h"
#include "cache.h"
#include "deps.h"


/** Check if pkg1 conflicts with pkg2
 * @param pkg1 package we are looking at
 * @param conflict name of the possible conflict
 * @param pkg2 package to check
 * @return 0 for no conflict, non-zero otherwise
 */
static int does_conflict(pmpkg_t *pkg1, const char *conflict, pmpkg_t *pkg2)
{
  const char *pkg1name = alpm_pkg_get_name(pkg1);
  const char *pkg2name = alpm_pkg_get_name(pkg2);
  pmdepend_t *conf = alpm_splitdep(conflict);
  int match = 0;

  match = alpm_depcmp(pkg2, conf);
  if(match) {
    _alpm_log(PM_LOG_DEBUG, "package %s conflicts with %s (by %s)\n",
        pkg1name, pkg2name, conflict);
  }
  FREE(conf);
  return(match);
}

/** Adds the pkg1/pkg2 conflict to the baddeps list
 * @param *baddeps list to add conflict to
 * @param pkg1 first package
 * @param pkg2 package causing conflict
 */
/* TODO WTF is a 'depmissing' doing indicating a conflict? */
static void add_conflict(alpm_list_t **baddeps, const char *pkg1,
    const char *pkg2)
{
  pmdepmissing_t *miss = _alpm_depmiss_new(pkg1, PM_DEP_TYPE_CONFLICT,
      PM_DEP_MOD_ANY, pkg2, NULL);
  if(miss && !_alpm_depmiss_isin(miss, *baddeps)) {
    *baddeps = alpm_list_add(*baddeps, miss);
  } else {
    FREE(miss);
  }
}

/** Check if packages from list1 conflict with packages from list2.
 * This looks at the conflicts fields of all packages from list1, and sees
 * if they match packages from list2.
 * If a conflict (pkg1, pkg2) is found, it is added to the baddeps list
 * in this order if order >= 0, or reverse order (pkg2,pkg1) otherwise.
 *
 * @param list1 first list of packages
 * @param list2 second list of packages
 * @param *baddeps list to store conflicts
 * @param order if >= 0 the conflict order is preserved, if < 0 it's reversed
 */
static void check_conflict(alpm_list_t *list1, alpm_list_t *list2,
    alpm_list_t **baddeps, int order) {
  alpm_list_t *i, *j, *k;

  if(!baddeps) {
    return;
  }
  for(i = list1; i; i = i->next) {
    pmpkg_t *pkg1 = i->data;
    const char *pkg1name = alpm_pkg_get_name(pkg1);

    for(j = alpm_pkg_get_conflicts(pkg1); j; j = j->next) {
      const char *conflict = j->data;

      for(k = list2; k; k = k->next) {
        pmpkg_t *pkg2 = k->data;
        const char *pkg2name = alpm_pkg_get_name(pkg2);

        if(strcmp(pkg1name, pkg2name) == 0) {
          /* skip the package we're currently processing */
          continue;
        }

        if(does_conflict(pkg1, conflict, pkg2)) {
          if(order >= 0) {
            add_conflict(baddeps, pkg1name, pkg2name);
          } else {
            add_conflict(baddeps, pkg2name, pkg1name);
          }
        }
      }
    }
  }
}

/* Returns a alpm_list_t* of pmdepmissing_t pointers. */
alpm_list_t *_alpm_checkconflicts(pmdb_t *db, alpm_list_t *packages)
{
  alpm_list_t *baddeps = NULL;

  ALPM_LOG_FUNC;

  if(db == NULL) {
    return(NULL);
  }

  alpm_list_t *dblist = alpm_list_diff(_alpm_db_get_pkgcache(db), packages,
      _alpm_pkg_cmp);

  /* three checks to be done here for conflicts */
  _alpm_log(PM_LOG_DEBUG, "check targets vs db\n");
  check_conflict(packages, dblist, &baddeps, 1);
  _alpm_log(PM_LOG_DEBUG, "check db vs targets\n");
  check_conflict(dblist, packages, &baddeps, -1);
  _alpm_log(PM_LOG_DEBUG, "check targets vs targets\n");
  check_conflict(packages, packages, &baddeps, 0);

  alpm_list_free(dblist);
  return(baddeps);
}

/* Returns a alpm_list_t* of file conflicts.
 *  Hooray for set-intersects!
 *  Pre-condition: both lists are sorted!
 */
static alpm_list_t *chk_fileconflicts(alpm_list_t *filesA, alpm_list_t *filesB)
{
  alpm_list_t *ret = NULL;
  alpm_list_t *pA = filesA, *pB = filesB;

  while(pA && pB) {
    const char *strA = pA->data;
    const char *strB = pB->data;
    /* skip directories, we don't care about dir conflicts */
    if(strA[strlen(strA)-1] == '/') {
      pA = pA->next;
    } else if(strB[strlen(strB)-1] == '/') {
      pB = pB->next;
    } else {
      int cmp = strcmp(strA, strB);
      if(cmp < 0) {
        /* item only in filesA, ignore it */
        pA = pA->next;
      } else if(cmp > 0) {
        /* item only in filesB, ignore it */
        pB = pB->next;
      } else {
        /* item in both, record it */
        ret = alpm_list_add(ret, strdup(strA));
        pA = pA->next;
        pB = pB->next;
      }
    }
  }

  return(ret);
}

/* Returns a alpm_list_t* of files that are in filesA but *NOT* in filesB
 *  This is an 'A minus B' set operation
 *  Pre-condition: both lists are sorted!
 */
static alpm_list_t *chk_filedifference(alpm_list_t *filesA, alpm_list_t *filesB)
{
  alpm_list_t *ret = NULL;
  alpm_list_t *pA = filesA, *pB = filesB;

  while(pA && pB) {
    const char *strA = pA->data;
    const char *strB = pB->data;
    /* skip directories, we don't care about dir conflicts */
    if(strA[strlen(strA)-1] == '/') {
      pA = pA->next;
    } else if(strB[strlen(strB)-1] == '/') {
      pB = pB->next;
    } else {
      int cmp = strcmp(strA, strB);
      if(cmp < 0) {
        /* item only in filesA, record it */
        ret = alpm_list_add(ret, strdup(strA));
        pA = pA->next;
      } else if(cmp > 0) {
        /* item only in fileB, but this means nothing */
        pB = pB->next;
      } else {
        /* item in both, ignore it */
        pA = pA->next;
        pB = pB->next;
      }
    }
  }

  return(ret);
}

/* Adds pmconflict_t to a conflicts list. Pass the conflicts list, type (either
 * PM_CONFLICT_TYPE_TARGET or PM_CONFLICT_TYPE_FILE), a file string, and either
 * two package names or one package name and NULL. This is a wrapper for former
 * functionality that was done inline.
 */
static alpm_list_t *add_fileconflict(alpm_list_t *conflicts,
                    pmconflicttype_t type, const char *filestr,
                    const char* name1, const char* name2)
{
  pmconflict_t *conflict;
  MALLOC(conflict, sizeof(pmconflict_t), return(conflicts));

  conflict->type = type;
  strncpy(conflict->target, name1, PKG_NAME_LEN);
  strncpy(conflict->file, filestr, CONFLICT_FILE_LEN);
  if(name2) {
    strncpy(conflict->ctarget, name2, PKG_NAME_LEN);
  } else {
    conflict->ctarget[0] = '\0';
  }

  conflicts = alpm_list_add(conflicts, conflict);
  _alpm_log(PM_LOG_DEBUG, "found file conflict %s, packages %s and %s\n",
            filestr, name1, name2 ? name2 : "(filesystem)");

  return(conflicts);
}

/* Find file conflicts that may occur during the transaction with two checks:
 * 1: check every target against every target
 * 2: check every target against the filesystem */
alpm_list_t *_alpm_db_find_conflicts(pmdb_t *db, pmtrans_t *trans, char *root)
{
  alpm_list_t *i, *conflicts = NULL;
  alpm_list_t *targets = trans->packages;
  int numtargs = alpm_list_count(targets);
  int current;

  ALPM_LOG_FUNC;

  if(db == NULL || targets == NULL || root == NULL) {
    return(NULL);
  }

  /* TODO this whole function needs a huge change, which hopefully will
   * be possible with real transactions. Right now we only do half as much
   * here as we do when we actually extract files in add.c with our 12
   * different cases. */
  for(current = 1, i = targets; i; i = i->next, current++) {
    alpm_list_t *j, *k, *tmpfiles = NULL;
    pmpkg_t *p1, *p2, *dbpkg;
    char path[PATH_MAX+1];

    p1 = i->data;
    if(!p1) {
      continue;
    }

    double percent = (double)current / numtargs;
    PROGRESS(trans, PM_TRANS_PROGRESS_CONFLICTS_START, "", (percent * 100),
             numtargs, current);
    /* CHECK 1: check every target against every target */
    for(j = i->next; j; j = j->next) {
      p2 = j->data;
      if(!p2) {
        continue;
      }
      _alpm_log(PM_LOG_DEBUG, "searching for file conflicts: %s and %s\n",
                alpm_pkg_get_name(p1), alpm_pkg_get_name(p2));
      tmpfiles = chk_fileconflicts(alpm_pkg_get_files(p1), alpm_pkg_get_files(p2));

      if(tmpfiles) {
        for(k = tmpfiles; k; k = k->next) {
          snprintf(path, PATH_MAX, "%s%s", root, (char *)k->data);
          conflicts = add_fileconflict(conflicts, PM_CONFLICT_TYPE_TARGET, path,
                                       alpm_pkg_get_name(p1), alpm_pkg_get_name(p2));
        }
        FREELIST(tmpfiles);
      }
    }

    /* declarations for second check */
    struct stat lsbuf, sbuf;
    char *filestr = NULL;

    /* CHECK 2: check every target against the filesystem */
    _alpm_log(PM_LOG_DEBUG, "searching for filesystem conflicts: %s\n", p1->name);
    dbpkg = _alpm_db_get_pkgfromcache(db, p1->name);

    /* Do two different checks here. f the package is currently installed,
     * then only check files that are new in the new package. If the package
     * is not currently installed, then simply stat the whole filelist */
    if(dbpkg) {
      /* older ver of package currently installed */
      tmpfiles = chk_filedifference(alpm_pkg_get_files(p1), alpm_pkg_get_files(dbpkg));
    } else {
      /* no version of package currently installed */
      tmpfiles = alpm_list_strdup(alpm_pkg_get_files(p1));
    }

    /* loop over each file to be installed */
    for(j = tmpfiles; j; j = j->next) {
      filestr = j->data;

      snprintf(path, PATH_MAX, "%s%s", root, filestr);

      /* stat the file - if it exists, do some checks */
      if(_alpm_lstat(path, &lsbuf) != 0) {
        continue;
      }
      stat(path, &sbuf);

      if(S_ISDIR(lsbuf.st_mode)) {
        _alpm_log(PM_LOG_DEBUG, "%s is a directory, not a conflict\n", path);
      } else if(S_ISLNK(lsbuf.st_mode) && S_ISDIR(sbuf.st_mode)) {
        _alpm_log(PM_LOG_DEBUG, "%s is a symlink to a dir, hopefully not a conflict\n", path);
      } else {
        _alpm_log(PM_LOG_DEBUG, "checking possible conflict: %s\n", path);

        /* Make sure the possible conflict is not a symlink that points to a
         * path in the old package. This is kind of dirty with inode usage */
        /* TODO this seems ripe for a cleanup */
        if(dbpkg) {
          struct stat pkgbuf;
          char str[PATH_MAX+1];
          unsigned ok = 0;
          for(k = dbpkg->files; k; k = k->next) {
            snprintf(str, PATH_MAX, "%s%s", root, (char*)k->data);
            if(!_alpm_lstat(str, &pkgbuf) && lsbuf.st_ino == pkgbuf.st_ino) {
              ok = 1;
              _alpm_log(PM_LOG_DEBUG, "conflict was a symlink: %s\n", path);
              break;
            }
          }
          if(ok == 1) {
            continue;
          }
        }

        /* Look at all the targets to see if file has changed hands */
        int resolved_conflict = 0/* have we acted on this conflict? */
        for(k = targets; k; k = k->next) {
          p2 = k->data;
          if(!p2 || strcmp(p1->name, p2->name) == 0) {
            continue;
          }

          pmpkg_t *localp2 = _alpm_db_get_pkgfromcache(db, p2->name);

          /* Check if it used to exist in a package, but doesn't anymore */
          alpm_list_t *pkgfiles, *localfiles; /* added for readability */
          pkgfiles = alpm_pkg_get_files(p2);
          localfiles = alpm_pkg_get_files(localp2);

          if(localp2 && !alpm_list_find_str(pkgfiles, filestr)
             && alpm_list_find_str(localfiles, filestr)) {
            /* check if the file is now in the backup array */
            if(alpm_list_find_str(alpm_pkg_get_backup(p1), filestr)) {
              /* keep file intact if it is in backup array */
              trans->skip_add = alpm_list_add(trans->skip_add, strdup(path));
              trans->skip_remove = alpm_list_add(trans->skip_remove, strdup(path));
              _alpm_log(PM_LOG_DEBUG, "file in backup array, adding to add and remove skiplist: %s\n", filestr);
              resolved_conflict = 1;
              break;
            } else {
              /* skip removal of file, but not add. this will prevent a second
               * package from removing the file when it was already installed
               * by its new owner */
              trans->skip_remove = alpm_list_add(trans->skip_remove, strdup(path));
              _alpm_log(PM_LOG_DEBUG, "file changed packages, adding to remove skiplist: %s\n", filestr);
              resolved_conflict = 1;
              break;
            }
          }
        }
        if(!resolved_conflict) {
          _alpm_log(PM_LOG_DEBUG, "file found in conflict: %s\n", path);
          conflicts = add_fileconflict(conflicts, PM_CONFLICT_TYPE_FILE,
                                       path, p1->name, NULL);
        }
      }
    }
    FREELIST(tmpfiles);
  }

  return(conflicts);
}

const char SYMEXPORT *alpm_conflict_get_target(pmconflict_t *conflict)
{
  ALPM_LOG_FUNC;

  /* Sanity checks */
  ASSERT(handle != NULLreturn(NULL));
  ASSERT(conflict != NULLreturn(NULL));

  return conflict->target;
}

pmconflicttype_t SYMEXPORT alpm_conflict_get_type(pmconflict_t *conflict)
{
  ALPM_LOG_FUNC;

  /* Sanity checks */
  ASSERT(handle != NULLreturn(-1));
  ASSERT(conflict != NULLreturn(-1));

  return conflict->type;
}

const char SYMEXPORT *alpm_conflict_get_file(pmconflict_t *conflict)
{
  ALPM_LOG_FUNC;

  /* Sanity checks */
  ASSERT(handle != NULLreturn(NULL));
  ASSERT(conflict != NULLreturn(NULL));

  return conflict->file;
}

const char SYMEXPORT *alpm_conflict_get_ctarget(pmconflict_t *conflict)
{
  ALPM_LOG_FUNC;

  /* Sanity checks */
  ASSERT(handle != NULLreturn(NULL));
  ASSERT(conflict != NULLreturn(NULL));

  return conflict->ctarget;
}
/* vim: set ts=2 sw=2 noet: */